Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for search related individuals #3928

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

litvinovg
Copy link
Collaborator

Related Vitro PR

What does this pull request do?

Translations for VIVO individuals presented on search results page

@chenejac Added translations for different languages. We need reviews from native speakers.

litvinovg and others added 2 commits December 19, 2023 12:07
…search_individuals_vivo.n3

Co-authored-by: Ivan R. Mršulja <nighteliteace@gmail.com>
…search_individuals_vivo.n3

Co-authored-by: Ivan R. Mršulja <nighteliteace@gmail.com>
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg the search query (created at the home page) is lost if locale is changed. I am wondering whether you can switch http method of the form to be GET instead of POST at the home page? I mean something similar as you already did for Vitro here? It should be also applied for VIVO themes (I suggest to do that for all three themes):

@litvinovg
Copy link
Collaborator Author

@litvinovg the search query (created at the home page) is lost if locale is changed. I am wondering whether you can switch http method of the form to be GET instead of POST at the home page? I mean something similar as you already did for Vitro here? It should be also applied for VIVO themes (I suggest to do that for all three themes):

* https://github.com/vivo-project/VIVO/blob/75a1df02cb30b4c3d7cf2c571ee9b925fce213b1/webapp/src/main/webapp/themes/wilma/templates/page-home.ftl#L47

* https://github.com/vivo-project/VIVO/blob/75a1df02cb30b4c3d7cf2c571ee9b925fce213b1/webapp/src/main/webapp/themes/tenderfoot/templates/page/page-home.ftl#L43

* https://github.com/vivo-project/VIVO/blob/75a1df02cb30b4c3d7cf2c571ee9b925fce213b1/webapp/src/main/webapp/themes/nemo/templates/page-home.ftl#L43

Done

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@chenejac chenejac requested a review from milospp January 16, 2024 12:21
@chenejac chenejac merged commit 4f2bb5e into vivo-project:main Feb 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants