[VIVO-1436] Implementation of Advanced Role Management #85
Conversation
There was a problem hiding this comment.
home/src/main/resources/rdf/display/firsttime/PropertyConfig.n3 and
home/src/main/resources/rdf/tbox/firsttime/vitroAnnotations.n3
still contain hundreds of references to
http://vitro.mannlib.cornell.edu/ns/vitro/0.7#hiddenFromDisplayBelowRoleLevelAnnot,
http://vitro.mannlib.cornell.edu/ns/vitro/0.7#prohibitedFromUpdateBelowRoleLevelAnnot, and
http://vitro.mannlib.cornell.edu/ns/vitro/0.7#hiddenFromDisplayBelowRoleLevelAnnot
There was a problem hiding this comment.
This is my full list of review points, including comments on unused code, commented code, undocumented methods, and others.
Since the project doesn't have a style guide, these are simply observations. Act on them or not, as you see fit.
VIVO - main
edu.cornell.mannlib.vivo.auth.policy.InfoContentEntityChecker
| lines 7, 9 | Logic | imports of PolicyDecision and AbstractPropertyStatementAction are not used. |
edu.cornell.mannlib.vivo.auth.policy.SelfEditorRelationship
| line 43 | Style | Why use a nested class? |
| line 46 | Logic | This line has no function. |
edu.cornell.mannlib.vivo.auth.policy.AdvisingRelationshipChecker
| lines 7, 9 | Logic | These import statements are not used. |
edu.cornell.mannlib.vivo.auth.policy.CourseChecker
| lines 7, 9 | Logic | These import statements are not used. |
edu.cornell.mannlib.vivo.auth.policy.GrantChecker
| lines 7, 9 | Logic | These import statements are not used. |
edu.cornell.mannlib.vivo.auth.policy.PresentationChecker
| lines 7,9 | Logic | These import statements are not used. |
edu.cornell.mannlib.vivo.auth.policy.ProjectOrServiceChecker
| lines 7, 9 | Logic | These import statements are not used. |
VIVO - home
src/main/resources/rdf/auth/firsttime/permission_entities.n3
OK
VIVO - webapp
src/main/webapp/WEB-INF/resources/startup_listeners.txt
OK
| public static class Setup implements ServletContextListener { | ||
| @Override | ||
| public void contextInitialized(ServletContextEvent sce) { | ||
| ServletContext ctx = sce.getServletContext(); |
There was a problem hiding this comment.
The ctx variable does not appear to be used... and can likely be removed.
| @@ -33,6 +33,9 @@ edu.cornell.mannlib.vitro.webapp.servlet.setup.FileGraphSetup | |||
| # edu.cornell.mannlib.vitro.webapp.migration.rel17.Release17Migrator | |||
| edu.cornell.mannlib.vitro.webapp.migration.rel18.Release18Migrator | |||
|
|
|||
| edu.cornell.mannlib.vitro.webapp.migration.auth.AuthMigrator | |||
There was a problem hiding this comment.
Please add a comment describing this migrator.
|
@j2blake The issues with leftover roles in the ontology files was a deliberate choice - it is relatively easy (albeit slightly time consuming) to delete lines that are no longer required. However, not knowing how long it will take to review the role management, or what might happen in ontology development in that time, I was hoping to reduce potential merge problems by delaying removing the old permissions. |
|
@j2blake About the nested class in SelfEditorRelationship - it was done for consistency with other setup code that is called from startup_listeners.txt. I've added a comment to the class. |
From:
- Vitro: vivo-project#80
- VIVO: vivo-project/VIVO#85
Resolves:
https://github.com/vivo-project/Vitro/pull/80/files#r227428235
https://github.com/vivo-project/Vitro/pull/80/files#r227892906
https://github.com/vivo-project/Vitro/pull/80/files#r227905400
https://github.com/vivo-project/Vitro/pull/80/files#r227907884
https://github.com/vivo-project/Vitro/pull/80/files#r227909775
https://github.com/vivo-project/Vitro/pull/80/files#r227913953
https://github.com/vivo-project/Vitro/pull/80/files#r227913145
https://github.com/vivo-project/Vitro/pull/80/files#r227913209
https://github.com/vivo-project/Vitro/pull/80/files#r227914673
https://github.com/vivo-project/Vitro/pull/80/files#r227915444
https://github.com/vivo-project/Vitro/pull/80/files#r227960329
Not addresses:
https://github.com/vivo-project/Vitro/pull/80/files#r227429141
https://github.com/vivo-project/Vitro/pull/80/files#r227434076
From: - Vitro: vivo-project/Vitro#80 - VIVO: vivo-project#85 Resolves: https://github.com/vivo-project/Vitro/pull/80/files#r227428235 https://github.com/vivo-project/Vitro/pull/80/files#r227892906 https://github.com/vivo-project/Vitro/pull/80/files#r227905400 https://github.com/vivo-project/Vitro/pull/80/files#r227907884 https://github.com/vivo-project/Vitro/pull/80/files#r227909775 https://github.com/vivo-project/Vitro/pull/80/files#r227913953 https://github.com/vivo-project/Vitro/pull/80/files#r227913145 https://github.com/vivo-project/Vitro/pull/80/files#r227913209 https://github.com/vivo-project/Vitro/pull/80/files#r227914673 https://github.com/vivo-project/Vitro/pull/80/files#r227915444 https://github.com/vivo-project/Vitro/pull/80/files#r227960329 Not addresses: https://github.com/vivo-project/Vitro/pull/80/files#r227429141 https://github.com/vivo-project/Vitro/pull/80/files#r227434076
…to feature/arm
|
Reopening this pull request. In an effort to follow current best practices, the VIVO project will now be developed against the |
* Add 'home' files into build war artifact Related to: https://jira.lyrasis.org/browse/VIVO-1443 * Disable copying exploded war to Tomcat dir - hardcode vivo.all.log file name - must now set system property: -Dvivo-dir=/opt/vivo/home/ Related to: https://jira.lyrasis.org/browse/VIVO-1443 * Ensure build does not remove and re-add VIVO_HOME/rdf Related to: https://jira.lyrasis.org/browse/VIVO-1443 * Remove unnecessary profile from installer/pom.xml Related to: https://jira.lyrasis.org/browse/VIVO-1443 * Rename example config files to have 'default' prefix Related to: https://jira.lyrasis.org/browse/VIVO-1443 * Require common properties to be in JNDI Properties include: - vitro/home - vitro/appName - vitro/rootUserAddress - vitro/defaultNamespace Related to: https://jira.lyrasis.org/browse/VIVO-1443 * VIVO-1443: app name (#2) * Non-functional change to comment in example.applicationSetup.n3 Related to: https://jira.lyrasis.org/browse/VIVO-1741 * Update orcidConfirm.ftl (vivo-project#199) * remove example-settings.xml * simplify war name and afford override during build * default app name to vivo and pass into context.xml Co-authored-by: Andrew Woods <awoods@duraspace.org> Co-authored-by: L.O <53535673+lb-ov@users.noreply.github.com> Co-authored-by: Andrew Woods <awoods@duraspace.org> Co-authored-by: William Welling <wwelling@library.tamu.edu> Co-authored-by: L.O <53535673+lb-ov@users.noreply.github.com>
|
Superseded by #3887 |
Reopening as old pull request was incorrect
See vivo-project/Vitro#80 for details