[VIVO-1436] Address code review comments on PR #85 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: - Vitro: vivo-project/Vitro#80 - VIVO: vivo-project#85 Resolves: https://github.com/vivo-project/Vitro/pull/80/files#r227428235 https://github.com/vivo-project/Vitro/pull/80/files#r227892906 https://github.com/vivo-project/Vitro/pull/80/files#r227905400 https://github.com/vivo-project/Vitro/pull/80/files#r227907884 https://github.com/vivo-project/Vitro/pull/80/files#r227909775 https://github.com/vivo-project/Vitro/pull/80/files#r227913953 https://github.com/vivo-project/Vitro/pull/80/files#r227913145 https://github.com/vivo-project/Vitro/pull/80/files#r227913209 https://github.com/vivo-project/Vitro/pull/80/files#r227914673 https://github.com/vivo-project/Vitro/pull/80/files#r227915444 https://github.com/vivo-project/Vitro/pull/80/files#r227960329 Not addresses: https://github.com/vivo-project/Vitro/pull/80/files#r227429141 https://github.com/vivo-project/Vitro/pull/80/files#r227434076
gneissone
changed the title
gneissone
changed the title
chenejac
pushed a commit
to chenejac/VIVO
that referenced
this pull request
Sep 29, 2022
vivo-project#95) * Remove non-language-specific Vitro annotations from vitroAnnotations_en_US.n3. Add language tags to vitro:fullPropertyNameAnnot values. * Remove redundant properties from fr_CA and de_DE vitro annotations files. Move a small number of rdfs:label properties from en_US vitro annotations to en_US initial TBox annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From:
Resolves:
https://github.com/vivo-project/Vitro/pull/80/files#r227428235
https://github.com/vivo-project/Vitro/pull/80/files#r227892906
https://github.com/vivo-project/Vitro/pull/80/files#r227905400
https://github.com/vivo-project/Vitro/pull/80/files#r227907884
https://github.com/vivo-project/Vitro/pull/80/files#r227909775
https://github.com/vivo-project/Vitro/pull/80/files#r227913953
https://github.com/vivo-project/Vitro/pull/80/files#r227913145
https://github.com/vivo-project/Vitro/pull/80/files#r227913209
https://github.com/vivo-project/Vitro/pull/80/files#r227914673
https://github.com/vivo-project/Vitro/pull/80/files#r227915444
https://github.com/vivo-project/Vitro/pull/80/files#r227960329
Not addresses:
https://github.com/vivo-project/Vitro/pull/80/files#r227429141
https://github.com/vivo-project/Vitro/pull/80/files#r227434076
Thank you for submitting a pull request! Title this pull request with a brief description of what the pull request fixes/improves/changes. Please describe the pull request in detail using the template below.
JIRA Issue: (please link to issue)
What does this pull request do?
A brief description of what the intended result of the PR will be and/or what problem it solves.
What's new?
An in-depth description of the changes made by this PR. Technical details and possible side effects. Include screenshots if appropriate.
Example:
How should this be tested?
A description of what steps someone could take to:
Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.
Example:
Interested parties
Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers