Extended search #382
Merged
Extended search #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
requested changes
Apr 21, 2023
There was a problem hiding this comment.
@litvinovg thanks for this PR. It looks very nice. It works as it is described. I have posted a couple of comments. Besides those comments, I have also one additional remark:
- Should we include in the codebase some searchSettings.n3? It might be really basic one, and also provide some additional documentation at wiki how to customize the search page. I am afraid if we don't have that basic configuration included, the VIVO customers wouldn't be aware and wouldn't use this new functionality.
webapp/src/main/webapp/templates/freemarker/page/partials/remote-search.ftl
Outdated
Show resolved
Hide resolved
...pp/src/main/webapp/templates/freemarker/body/extendedsearch/extended-search-pagedResults.ftl
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/tbox/firsttime/classGroupAnnotationsVitro.n3
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/i18n/en_US/tbox/firsttime/searchOntology.n3
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/i18n/en_US/interface-i18n/firsttime/vitro_extended_search.ttl
Outdated
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/SearchFiltering.java
Outdated
Show resolved
Hide resolved
...c/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/ExtendedSearchController.java
Outdated
Show resolved
Hide resolved
I think we should create and add one. Maybe as an update to VIVO PR. |
chenejac
requested review from
brianjlowe and
a user
and removed request for
ivanmrsulja
litvinovg
force-pushed
the
extended_search
branch
from
0e325e7
to
5e7fab6
Compare
litvinovg
force-pushed
the
extended_search
branch
from
5e7fab6
to
4b05a1b
Compare
chenejac
requested changes
Sep 27, 2023
There was a problem hiding this comment.
@litvinovg Export of search results includes only the first page results (usually 30 results) in both format csv and xml. Besides that I have added a couple of more minor comments.
home/src/main/resources/rdf/i18n/en_US/tbox/firsttime/searchOntology.n3
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/tbox/firsttime/classGroupAnnotationsVitro.n3
Outdated
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/VitroSearchTermNames.java
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/PagedSearchController.java
Outdated
Show resolved
Hide resolved
|
Fixed export in csv and xml |
ivanmrsulja
reviewed
Oct 2, 2023
api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/SearchFilter.java
Outdated
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/SearchFilterGroup.java
Outdated
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchengine/solr/SolrFieldInitializer.java
Outdated
Show resolved
Hide resolved
ivanmrsulja
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO PR
What does this pull request do?
Introduces extended search to Vitro
What's new?
Added extended search controller
Added search ontology
Created search class group
Bootstrap migrated from VIVO tenderfoot theme
Modified freemarker files to support extended search.
Solr field type dateRange and dynamic field *_drsim should be created on startup
How should this be tested?
Check logs to verify that field type dateRange and dynamic field *_drsim has been created on startup
[SolrFieldInitializer] Solr field type 'dateRange' not found. Trying to create.[SolrFieldInitializer] Solr field type 'dateRange' has been created.[SolrFieldInitializer] Solr dynamic field '*_drsim' of type dateRange not found. Trying to create.[SolrFieldInitializer] Solr dateRange dynamic field '*_drsim' has been created.Add sample data and example search settings attached below
example-search-settings.nt.zip
Try search, create new document modifiers, search filters
Notes
Additional Solr field configuration (autocreated on startup)
<dynamicField name="*_drsim" type="dateRange" stored="true" indexed="true" multiValued="true"/><fieldType name="dateRange" class="solr.DateRangeField"/>New dependencies
js: noUiSlider
js: wnumb
Interested parties
@VIVO-project/vivo-committers
@chenejac