New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript types for data.records are too restrictive #29

Closed

christopher-caldwell opened this issue Oct 19, 2021 · 1 comment

christopher-caldwell commented Oct 19, 2021

Apologies for all the TS issues, please let me know if it's too much.

The records are only allowed to be strings, but I think numbers are valid as well.

interface Table1NF extends Filter {
  /** The list of the data series that make up the data set. */
  series?: Series[];
  /** The array of data records to be appended to the end of the data set. */
  records?: string[][];
}

Should the records only be strings? I have added a //@ts-ignore and this works with numbers. This [fiddle] also shows with numbers.

The text was updated successfully, but these errors were encountered:

simzer closed this as completed in

70c70ae

Member

simzer commented Oct 19, 2021

Thanks, it actually helps a lot, so please keep up the bug reporting if you find anything.

simzer added a commit to simzer/vizzu-lib that referenced this issue


          TableByRecords fixed in d.ts file. fix vizzuhq#29

1aba9a2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment