Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: animOptions support with Keyframes #25

Merged
merged 6 commits into from
May 9, 2023

Conversation

dyuri
Copy link
Collaborator

@dyuri dyuri commented Jan 2, 2023

Instead of manually handling "sub-slides", uses the new (currently unreleased) vizzu keyframes.

DO NOT RELEASE until vizzu keyframe support is released.

Closes #24.

@dyuri
Copy link
Collaborator Author

dyuri commented Jan 2, 2023

Switch from sub-slides to keyframes is basically done, need some cleanup to remove some unnecessary arrays and such.

@dyuri
Copy link
Collaborator Author

dyuri commented Jan 2, 2023

Subslide concept removed.

@veghdev
Copy link
Member

veghdev commented Mar 7, 2023

@dyuri I merged main into it so it uses the correct Vizzu.
The expected test values should be fixed, but as I can see the feature does not work well. You can see in the docs example, for example only step 2 of the thrid slide is animated.

@dyuri
Copy link
Collaborator Author

dyuri commented Mar 7, 2023

I don't know how it's supposed to work, but since this player doesn't do much but calls the vizzu library, the issue might be there too. I've just removed the manual handling of sub-slides.

@dyuri dyuri marked this pull request as ready for review March 7, 2023 12:33
@simzer
Copy link
Member

simzer commented Mar 7, 2023

@dyuri The problem seems to be that while vizzu-story calls vizzu.animate with the list of keyframes now, it still stores only the end chart:

await this.vizzu.animate(animParams);
chartSteps.push(this.vizzu.store());

To be able to work correctly, it should store the whole animation:

let animation = this.vizzu.animate(animParams);
let control = await animation.activated;
chartSteps.push(control.store());
await animation;

@dyuri dyuri marked this pull request as draft April 11, 2023 15:16
@dyuri
Copy link
Collaborator Author

dyuri commented Apr 11, 2023

tests are broken due to the API change :/

@simzer simzer marked this pull request as ready for review April 12, 2023 14:10
@simzer
Copy link
Member

simzer commented Apr 19, 2023

See comment on the issue: #26 (comment)

@veghdev veghdev changed the title keyframes Added: animOptions support with Keyframes May 9, 2023
@veghdev veghdev merged commit 9c0f06d into vizzuhq:main May 9, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

development: use new keyframe support of vizzu + add slider
3 participants