Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the edit item dialog #1082

Merged
merged 5 commits into from Jun 11, 2022
Merged

Replace the edit item dialog #1082

merged 5 commits into from Jun 11, 2022

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jun 11, 2022

Summary:

This PR adds a simple text editing dialog for editing labels. It behaves similarly to the QInputDialog, but with a few improvements to the layout.

Sine the context menu in the project tree now can change all settings of a project item, the old GuiItemEditor dialog has been removed. To preserve the possibility to edit items in the project tree without using the mouse, the shortcut Ctrl+. will now open the context menu on the selected item, just like in the document editor.

This change renders feature #997 obsolete.

Related Issue(s):

Closes #997

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 1.7 Beta 2 milestone Jun 11, 2022
@vkbo vkbo merged commit 5a5a64e into main Jun 11, 2022
@vkbo vkbo deleted the item_edit_dialog branch June 11, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a create new item dialog, or improve edit item dialog
1 participant