Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theming #68

Closed
sandorex opened this issue Dec 6, 2022 · 8 comments
Closed

Dark theming #68

sandorex opened this issue Dec 6, 2022 · 8 comments

Comments

@sandorex
Copy link

sandorex commented Dec 6, 2022

I would like if there was builtin dark theme

@vkurko
Copy link
Owner

vkurko commented Dec 6, 2022

Hi @sandorex

Unfortunately, there is no built-in dark theme. But I think it's enough to override no more than a dozen classes to make such a theme. If you succeed, please share the result 😄

@sandorex
Copy link
Author

sandorex commented Dec 6, 2022

I suck at css but when i get around to it ill post it 😄

@oendnsk675
Copy link

Hi @sandorex

Unfortunately, there is no built-in dark theme. But I think it's enough to override no more than a dozen classes to make such a theme. If you succeed, please share the result 😄

I think it can help to add a dark mode feature later when free😁

@sandorex
Copy link
Author

sandorex commented Jan 18, 2023

I switched to fullcalendar, and borrowed some opensource code and got dark mode so i never made it, i really do hate CSS

@ademaro
Copy link
Contributor

ademaro commented Jul 11, 2023

I could do with creating a dark theme, make all colors via css variables, light/dark theme support via the prefers-color-scheme.

True it is quite labor-intensive and I can do it in my free time, if it is, of course, relevant to the project. What do you say?

Maybe something like this will work out:
dark

@vkurko
Copy link
Owner

vkurko commented Jul 11, 2023

What do you say?

Sure, please do it. You can also change the current light theme to use css variables

@cmjoseph07
Copy link

@ademaro

Please do this, that would be amazing!

ademaro added a commit to jokerinteractive/calendar that referenced this issue Aug 6, 2023
vkurko pushed a commit that referenced this issue Oct 12, 2023
* Added dark theme #68

* Added prefixes for css variables

* Removed global styles that affect the entire document

* Corrected typos

* Updated styles for demo page
@vkurko
Copy link
Owner

vkurko commented Oct 20, 2023

The dark theme is available since v2.4.0. Please see docs.

@vkurko vkurko closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants