-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better document the use of cookies/localstorage and the extension. (Saving of user options) #26
Comments
Hi! Thanks for the issue! However, the issue is valid - user settings are stored as long as the user doesn't clear their browser data. There are 2 possible ways of saving the user settings that I'm thinking about:
Anyway, this should exist in a feature version. |
Excellent idea's. I just want to add this link for the people who aren't following what the difference between cookies & local storage is. (Like myself, since I'm more of a networking guy than a programmer :P ) https://stackoverflow.com/questions/3220660/local-storage-vs-cookies |
@vlad-timotei , the 2nd option sounds amazing. Since an import/export feature now that I think of it... It would break over versions and such. |
This adds a drag and drop bookmark to save current settings. See: #26
See https://github.com/vlad-timotei/wpgp-tools/tree/one.five#backup--restore-settings
|
Excellent, but I do have a question... What will happen if you save an option but you upgrade to another version that has more options? |
Very good question. What do you think about checking if the backup version is older and then ask if it should restore or not? |
Just pushed this commit. User will have to confirm backup restore. Case A. Version of the backup is the same with the version user has installed. Case B. Version of the backup is not the same with the version user has installed. (Date and time have localized format) |
Now, I see you already implemented something for it... But I would say, options that aren't in the back-up go to default? |
That is correct. |
So, it turns out that #25 works just fine... But because I cleaned my cookies & browser cache, it """stopped""" working because, to quote @vlad-timotei himself: "It's very resource consuming this feature, so I only want people that need it to enable it."
So, to help new users or users who aren't too use to this tool... Maybe a warning message about the options being saved in a cookie (and maybe have an import/export feature in the long term) would be extremely handy and make the tool more user friendly imho.
The text was updated successfully, but these errors were encountered: