Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: process.getgid and process.getuid are not available on Windows #1

Merged
merged 1 commit into from
Jun 28, 2015

Conversation

pke
Copy link
Contributor

@pke pke commented Jun 28, 2015

Make the gid and uid properties optional and introduce a new pid property that is available on all platforms.

Although none of those is actually used in the report, they still threw up when running nodejs on a Windows machine.

Make the `gid` and `uid` properties optional and introduce a new `pid` property that is available on all platforms.
vladaspasic added a commit that referenced this pull request Jun 28, 2015
Fix: process.getgid and process.getuid are not available on Windows
@vladaspasic vladaspasic merged commit 577d1bd into vladaspasic:master Jun 28, 2015
@vladaspasic
Copy link
Owner

Thank you @pke, I did not test how this would work on Win platforms.

@pke
Copy link
Contributor Author

pke commented Aug 5, 2015

Could you please release an updated NPM package? I run a fresh npm install and got still the buggy 0.0.4 version installed. Thanks! Nevermind, I had my package.json locked to max 0.0.4

@vladaspasic
Copy link
Owner

Sorry @pke you had to wait, I forgot to release it.

New version is now available.

@pke
Copy link
Contributor Author

pke commented Aug 5, 2015

Thanks, I guess we have to wait a bit until the npm repos are updated?

@vladaspasic
Copy link
Owner

I do not think so, it should be available immediately. Try loading the dependency with a fixed 0.0.6 version in your package.json.

@pke
Copy link
Contributor Author

pke commented Aug 5, 2015

Yes, thanks it worked!

@pke pke deleted the patch-1 branch November 14, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants