Tools not built in subfolders with build-tools

[lcheylus]

Describe the bug

With the last V version (V 0.4.5 f6a00fa), I have an error when I'm trying to build tools (cmd/tools/) with build-tools target. Tools with sources in sub-directories (vast, vcreate, vdoc, vpm, vvet and vwhere) are not built.

Same error with build on Linux Debian/amd64 and OpenBSD-current/amd64.

Reproduction Steps

• Clone sources via git clone
• Build V compiler via make
• Build tools with ./v build-tools

=> tools in sub-directories are not built.

Expected Behavior

Every tool in cmd/tools and sub-directories are built with ./v build-tools

Current Behavior

Tools with sources in sub-directories (vast, vcreate, vdoc, vpm, vvet and vwhere) are not built with ./v build-tools.

Possible Solution

After some code analysis, this issue was not present in V version 0.4.4. It seems that commit 6a4f293 is the root cause.

• cmd/tools/vbuild-tools.v: vast, vcreate, vdoc, vpm, vvet and vwhere (sources in sub folders) are initially skipped, then added into a test session.
• cmd/tools/modules/testing/common.v: function worker_trunner, line 546, build is skipped for the tools list above.

I have a working fix : line 546 => if !ts.build_tools && (abs_path in ts.skip_files)

With this fix, every tool are built during ./v build-tools

I am going to submit a PR with this fix.

V version

V 0.4.5 f6a00fa

Environment details (OS name and version, etc.)

• Linux Debian testing/amd64
• OpenBSD current/amd64

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.