Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgen: fix comptime is condition when using interface #20952

Merged
merged 2 commits into from
Mar 4, 2024
Merged

cgen: fix comptime is condition when using interface #20952

merged 2 commits into from
Mar 4, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Mar 3, 2024 •
edited

Fix #20918

@felipensp felipensp marked this pull request as ready for review March 4, 2024 01:57
spytheman
spytheman approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit a3bb422 into vlang:master Mar 4, 2024
54 checks passed
@felipensp felipensp deleted the fix_comptime_is_expr branch March 4, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional type matches incorrectly in $for field
2 participants
@felipensp @spytheman