picoev: handle EAGAIN
or EWOULDBLOCK
quietly
#21480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C
recv
andaccept
calls can reply withEAGAIN
orEWOULDBLOCK
on a-1
return value, which is to be expected for the asynchronous picoev event loop server.Fix #21316 by continuing silently in these cases.
As a runtime asynchronous bug, the test is a stressful benchmark. In one terminal:
In another (on a 24-core machine):
After this patch, there are no
Error during req_read
orError during accept
messages. 👍