This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Add Vital100S and Vital200S support #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These devices use a different module name from the other air purifiers and are thus currently ignored.
|
Kudos, SonarCloud Quality Gate passed!
|
|
I just spent the last hour figuring this out and came to the same conclusion. Adding the correct module name fixes the issue. |
|
thanks for the PR, and sorry for the silence, not much time lately... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These devices use a different module name from the other air purifiers and are thus currently ignored. Adding this module name as a fan type fixes it.