Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ActorInstantiator #59

Merged
merged 2 commits into from
Jan 12, 2020
Merged

Simplify ActorInstantiator #59

merged 2 commits into from
Jan 12, 2020

Conversation

kmruiz
Copy link
Contributor

@kmruiz kmruiz commented Jan 11, 2020

  • Remove what seems unused classes (ActorInstantiator.Registry)
  • Because ActorInstantiator.type() is unused, mark it as default and return null so it doesn't break the current contract.
  • PrivateRootActor, PublicRootActor and DeadletterActor now uses instantiators.
  • Default plugins do not use reflection now.
  • Use beforeStart hooks to bind internal actors, instead of the constructor.
  • Added vlingo-reflection so the compiler plugin now generates the required reflection.json

Copy link
Contributor

@VaughnVernon VaughnVernon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmruiz Awesome!

@VaughnVernon VaughnVernon merged commit d8ebfe9 into master Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants