Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor Fix] Fix comments in benchmark_serving #3252

Merged
merged 4 commits into from
Mar 8, 2024
Merged

[Minor Fix] Fix comments in benchmark_serving #3252

merged 4 commits into from
Mar 8, 2024

Conversation

gty111
Copy link
Contributor

@gty111 gty111 commented Mar 7, 2024 •
edited

In benchmark_serving.py, --model is an required argument, while --tokenizer isn't a necessary argument.

When executing the following command

python benchmarks/benchmark_serving.py \
        --backend <backend> \
        --tokenizer <your_model> --dataset <target_dataset> \
        --request-rate <request_rate>

It will trigger error benchmark_serving.py: error: the following arguments are required: --model

ywang96
ywang96 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

Note - I will make the comments easier to read and include more information in #3194

zhuohan123
zhuohan123 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you fix the yapf error?

@gty111
Copy link
Contributor Author

gty111 commented Mar 8, 2024

LGTM! Can you fix the yapf error?

Sure. The yapf error is fixed now.

@simon-mo simon-mo enabled auto-merge (squash) March 8, 2024 06:22
@simon-mo simon-mo merged commit 1ece1ae into vllm-project:main Mar 8, 2024
21 of 23 checks passed
dtransposed pushed a commit to afeldman-nm/vllm that referenced this pull request Mar 26, 2024
@gty111
[Minor Fix] Fix comments in benchmark_serving (vllm-project#3252)
7dfb244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywang96 ywang96 ywang96 approved these changes

@zhuohan123 zhuohan123 zhuohan123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gty111 @zhuohan123 @ywang96 @simon-mo