Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Fix Unmocked Imports #3275

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[Docs] Fix Unmocked Imports #3275

merged 1 commit into from
Mar 8, 2024

Conversation

ywang96
Copy link
Collaborator

@ywang96 ywang96 commented Mar 8, 2024

Quick fix for #2996

I've tested it on RTD with my fork and the webpage was able to render properly.

@ywang96 ywang96 marked this pull request as ready for review March 8, 2024 07:52
@ywang96
Copy link
Collaborator Author

ywang96 commented Mar 8, 2024

https://vllm--3275.org.readthedocs.build/en/3275/dev/engine/llm_engine.html

cc @simon-mo PTAL, thanks!

@simon-mo simon-mo merged commit 99c3cfb into vllm-project:main Mar 8, 2024
21 of 23 checks passed
dtransposed pushed a commit to afeldman-nm/vllm that referenced this pull request Mar 26, 2024
@ywang96
[Docs] Fix Unmocked Imports (vllm-project#3275)
2b38009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ywang96 @simon-mo