Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add args for mTLS support #3410

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Add args for mTLS support #3410

merged 2 commits into from
Mar 14, 2024

Conversation

declark1
Copy link
Contributor

This PR exposes additional uvicorn TLS args ssl_ca_certs, ssl_cert_reqs to enable mTLS support.

@simon-mo simon-mo merged commit c17ca8e into vllm-project:main Mar 14, 2024
24 checks passed
@ywang96
Copy link
Collaborator

ywang96 commented Mar 15, 2024

@simon-mo Hmmm...this PR probably shouldn't be merged in the first place since it's making changes to vllm/entrypoints/api_server.py. I wonder if we should make a workflow to automatically warn user if the changes are being made to that file.

@declark1 Could you please make a PR to add this to vllm/entrypoints/openai/api_server.py as well?

@declark1
Copy link
Contributor Author

Thanks for pointing this out @ywang96, my apologies for missing that. I have opened a new PR to fix this.

@simon-mo
Copy link
Collaborator

I merged this because benchmarking over mTLS is a valid use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants