[Misc] Fix Benchmark TTFT Calculation for Chat Completions #3768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the TTFT calculation when running serving benchmark with chat completions API. Previously it didn't check if actual
content
isNull
in the delta, and thusrole
chunk with emptycontent
could be mistakenly treated as a real token response.Note: This does not affect existing CI results since by default
vLLM
uses completions instead of chat completions for benchmarking.Fixes #3759