Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: freeze pydantic to v1 #429

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix: freeze pydantic to v1 #429

merged 1 commit into from
Jul 12, 2023

Conversation

kemingy
Copy link
Contributor

@kemingy kemingy commented Jul 11, 2023

@zhuohan123 zhuohan123 self-requested a review July 12, 2023 15:09
zhuohan123
zhuohan123 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!

@zhuohan123 zhuohan123 merged commit 51be365 into vllm-project:main Jul 12, 2023
2 checks passed
@jens-create jens-create mentioned this pull request Oct 17, 2023
Closed
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@kemingy
fix: freeze pydantic to v1 (vllm-project#429)
c1e1ca7
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
@kemingy
fix: freeze pydantic to v1 (vllm-project#429)
98e451b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuohan123 zhuohan123 zhuohan123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pydantic v2 breaking FastAPI & Ray
2 participants
@kemingy @zhuohan123