Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pydantic to v2 #1396

Closed
jens-create opened this issue Oct 17, 2023 · 5 comments · Fixed by #2531
Closed

bump pydantic to v2 #1396

jens-create opened this issue Oct 17, 2023 · 5 comments · Fixed by #2531
Labels
enhancement New feature or request

Comments

@jens-create
Copy link

Would be it be possible to bump pydantic to v2 as ray [serve] is now compatible with pydantic v2? See Ray PR.

Follow up on issue #423 and PR #429.

@WoosukKwon WoosukKwon added the enhancement New feature or request label Oct 21, 2023
@WoosukKwon
Copy link
Collaborator

Hi @jens-create Thanks for bringing this up! We will definitely consider bumping up the version once they bump up the pydantic version in Ray.

@michaelfeil
Copy link
Contributor

Is there a follow-up on this?

@dbuades
Copy link

dbuades commented Dec 21, 2023

Just an FYI, Ray just released their 2.9.0 version, which adds support for Pydantic >=2.5.0

https://github.com/ray-project/ray/releases/tag/ray-2.9.0

CC @WoosukKwon

@Lawouach
Copy link

Hi all,

That would be quite good to upgrade, less and less projects will expect pydantic 1.x so the pin on 1.10 on vllm is a becoming a headache.

@jvmncs
Copy link
Contributor

jvmncs commented Jan 9, 2024

bumping this! there is an open PR for it here: #2322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants