[Frontend][Bugfix] Disallow extra fields in OpenAI API #4355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkLight1337
changed the title
- Also improve type annotations in the process
DarkLight1337
force-pushed
the
openai-no-extra-fields
branch
from
fd08b3f
to
8cf1fb3
Compare
|
The |
simon-mo
approved these changes
Apr 26, 2024
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
May 6, 2024
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 7, 2024
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Pydantic models for OpenAI API such that an error is raised when the API is called with extra fields. It also improves general type annotations in the
entrypointssubpackage.FIX #4339
Compatibility Changes
openaiwill be upgraded to acommondependency (fromdev) since users of the package may serve the OpenAI API. IMO, this should have been the case from the start.