[Core][Optimization] change python dict to pytorch tensor for blocks to swap #4659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
cadedaniel
reviewed
May 7, 2024
| assert (num_lookahead_slots == 0 | ||
| ), "BlockSpaceManagerV1 does not support lookahead allocation" | ||
|
|
||
| # CPU block -> GPU block. | ||
| # dict is efficient in lookup `if cpu_block in mapping` |
There was a problem hiding this comment.
is it a better approach if we do list(mapping.items()) in the worker layer?
There was a problem hiding this comment.
IMO the mapping semantics are better represented by dict[int, int], which is why I ask
There was a problem hiding this comment.
@cadedaniel This is basically for performance. List append/extend is faster than Dict insert/update.
cadedaniel
approved these changes
May 7, 2024
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 9, 2024
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
May 19, 2024
dtrifiro
pushed a commit
to dtrifiro/vllm
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue after #4607 .