-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core][Optimization] change python dict to pytorch tensor #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiuXiaoxuanPKU
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR!
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
May 7, 2024
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
May 19, 2024
dtrifiro
pushed a commit
to dtrifiro/vllm
that referenced
this pull request
May 21, 2024
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR,
blocks_to_copy
usesDict[int, List[int]]
type in Python, and convert tostd::map<int64_t, std::vector<int64_t>>&
in c++ . Although the type contains a reference&
, it is actually a copy. Inside the cpp code, we convert the data into pytorch array.In distributed setting, the cost is even larger:
blocks_to_copy
will be serialized, and broadcasted, deserialized, passed to c++, and finally convert to pytorch tensor.This PR changes the python side data structure to
List[Tuple[int, int]]
, and convert it once to pytorch tensor before broadcast. PyTorch tensor can be passed to c++ code without copy.The convertion is done by flatten the data, i.e.
old: Dict[int, List[int]]
,new = [(k, dst) for k, v in old.items() for dst in v]
.e.g.
old = {1: [2, 3, 4]}
,new = [(1, 2), (1, 3), (1, 4)]
.Future todo:
Dict[int, List[int]]
in block manager (in [Core][Optimization] change copy-on-write from dict[int, list] to list #4648 )blocks_to_swap_in
andblocks_to_swap_out
in the same way (in [Core][Optimization] change python dict to pytorch tensor for blocks to swap #4659 )