[Model] Initial support for BLIP-2 #5920
Open
+1,076
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DarkLight1337 Thank you very much for your work, looking forward to having BLIP-2 in Vllm! The two underlying PR were merged in Vllm! |
|
The implementation is done but it appears that the model has some numerical inaccuracies (as shown by the warnings and errors in CI). I will be busy for the next few days so any help with debugging this would be appreciated! |
|
Looks like it's an issue with |
|
@ywang96 I got the tests to pass, so we can merge this PR if it looks good to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement BLIP-2 model (tested with
Salesforce/blip2-opt-2.7b).FIX #4739