enhance Logging - Header Line, Date Formatter, parsed Date ... (#152)

* adjust logging levels - debug vs trace * add more logging - HeaderLine, Date Formatter, parsed Date, Start & End Dates * reverse change for VersionNumber
vlsi · Sep 24, 2018 · 3c56fbf · 3c56fbf
1 parent 72f2da0
commit 3c56fbf
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 14 deletions.
diff --git a/src/main/java/net/atomique/ksar/AllParser.java b/src/main/java/net/atomique/ksar/AllParser.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2017 The kSAR Project. All rights reserved.
+ * Copyright 2018 The kSAR Project. All rights reserved.
  * See the LICENSE file in the project root for more information.
  */
 
@@ -111,10 +111,9 @@ public boolean setDate(String s) {
         formatter = DateTimeFormatter.ofPattern(dateFormat);
       }
 
+      log.debug("Date formatter: {}",formatter);
       currentDate = LocalDate.parse(s, formatter);
 
-      parsedate = currentDate;
-
       startDate = LocalDate.parse(sarStartDate, formatter);
       endDate = LocalDate.parse(sarEndDate, formatter);
 
@@ -123,12 +122,15 @@ public boolean setDate(String s) {
       return false;
     }
 
+    parsedate = currentDate;
+
     if (currentDate.compareTo(startDate) < 0) {
       sarStartDate = s;
     }
     if (currentDate.compareTo(endDate) > 0) {
       sarEndDate = s;
     }
+    log.debug("parsedDate: {}, startDate: {}, EndDate: {}",currentDate, sarStartDate, sarEndDate);
     return true;
   }
 

diff --git a/src/main/java/net/atomique/ksar/Main.java b/src/main/java/net/atomique/ksar/Main.java
@@ -64,10 +64,9 @@ public static void main(String[] args) {
     int i = 0;
     String arg;
 
-    log.trace("main - Start");
-    log.trace("Java runtime Version : {}", System.getProperty("java.runtime.version"));
-    log.trace("Java runtime architecture : {}", System.getProperty("os.arch"));
     log.trace("ksar Version : {}", VersionNumber.getVersionNumber());
+    log.debug("Java runtime Version : {}", System.getProperty("java.runtime.version"));
+    log.debug("Java runtime architecture : {}", System.getProperty("os.arch"));
 
     /// load default - Mac OS X Application Properties
     String mrjVersion = System.getProperty("mrj.version");

diff --git a/src/main/java/net/atomique/ksar/kSar.java b/src/main/java/net/atomique/ksar/kSar.java
@@ -165,9 +165,9 @@ public int parse(BufferedReader br) {
 
     parsing_end = System.currentTimeMillis();
     if (GlobalOptions.isDodebug()) {
-      log.debug("time to parse: {} ms", (parsing_end - parsing_start));
+      log.trace("time to parse: {} ms", (parsing_end - parsing_start));
       if (myparser != null) {
-        log.debug("number of datesamples: {}", myparser.DateSamples.size());
+        log.trace("number of datesamples: {}", myparser.DateSamples.size());
       }
     }
     Parsing = false;

diff --git a/src/main/java/net/atomique/ksar/parser/Linux.java b/src/main/java/net/atomique/ksar/parser/Linux.java
@@ -33,6 +33,7 @@ public class Linux extends OSParser {
 
   public void parse_header(String s) {
 
+    log.debug("Header Line : {}", s);
     String[] columns = s.split("\\s+");
 
     String tmpstr;
@@ -70,12 +71,12 @@ private void checkDateFormat() {
         timeColumn = 2;
       }
     }
-
+    log.debug("Date Format: {}, Time Format: {}", dateFormat, timeFormat);
   }
 
   private void askDateFormat() {
 
-    log.debug("askDateFormat - provide date format");
+    log.trace("askDateFormat - provide date format");
     if (GlobalOptions.hasUI()) {
       LinuxDateFormat tmp = new LinuxDateFormat(GlobalOptions.getUI(), true);
       tmp.setTitle("Provide date format");

diff --git a/src/main/java/net/atomique/ksar/ui/DataView.java b/src/main/java/net/atomique/ksar/ui/DataView.java
@@ -213,10 +213,9 @@ private void jTree1ValueChanged(
     TreePath treepath = evt.getPath();
     Object obj = treepath.getLastPathComponent();
     if (obj != null) {
-      if (GlobalOptions.isDodebug()) {
-        log.debug("mem: {}", Runtime.getRuntime().totalMemory());
-        log.debug("free: {}", Runtime.getRuntime().freeMemory());
-      }
+
+      log.trace("mem: {}", Runtime.getRuntime().totalMemory());
+      log.trace("free: {}", Runtime.getRuntime().freeMemory());
 
       SortedTreeNode treenode = (SortedTreeNode) obj;
       if (treenode.getRoot() == treenode) {