-
Notifications
You must be signed in to change notification settings - Fork 50
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
4 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa4b1f7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all that is required for Bullet to work with Pimple v3?! Impressive.
aa4b1f7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
composer.json
still has"version": "1.3.6"
and so vlucas/bulletphp is not reading the new version.aa4b1f7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is all that is required for Bullet to handle it - your app, however, may be calling methods like
$app->share(...)
that were in Pimple 1.x, and will now no longer exist, causing fatal errors.I removed the
version
key incomposer.json
. This will allow Packagist to handle versioning automatically using tagged releases (which I already use anyways - the release you want is1.4.x
or~1.4.0
)