Skip to content

Commit

Permalink
BREAKING UPDATE: Use Pimple 3.x
Browse files Browse the repository at this point in the history
  • Loading branch information
vlucas committed Aug 25, 2014
1 parent fdf6913 commit aa4b1f7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
],
"require": {
"php": ">=5.3.2",
"pimple/pimple": "1.*"
"pimple/pimple": "3.*"
},
"autoload": {
"psr-0": {
Expand Down
4 changes: 3 additions & 1 deletion src/Bullet/App.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<?php
namespace Bullet;

class App extends \Pimple
use Pimple\Container;

class App extends Container
{
protected $_request;
protected $_response;
Expand Down

3 comments on commit aa4b1f7

@shadowhand
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all that is required for Bullet to work with Pimple v3?! Impressive.

@shadowhand
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer.json still has "version": "1.3.6" and so vlucas/bulletphp is not reading the new version.

@vlucas
Copy link
Owner Author

@vlucas vlucas commented on aa4b1f7 Aug 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is all that is required for Bullet to handle it - your app, however, may be calling methods like $app->share(...) that were in Pimple 1.x, and will now no longer exist, causing fatal errors.

I removed the version key in composer.json. This will allow Packagist to handle versioning automatically using tagged releases (which I already use anyways - the release you want is 1.4.x or ~1.4.0)

Please sign in to comment.