Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: demo #5

Open
1 of 2 tasks
gha3mi opened this issue Oct 29, 2023 · 1 comment
Open
1 of 2 tasks

Suggestion: demo #5

gha3mi opened this issue Oct 29, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@gha3mi
Copy link
Collaborator

gha3mi commented Oct 29, 2023 •
edited

  • Move all test results to the demo folder to keep the main directory clean.
  • Add the write_ppm_file_colorbar subroutine as a type-bound procedure for the Colormap type. Move write_ppm_file_test to demo.f90 since it's a specific subroutine for the demo.
@vmagnin
Copy link
Owner

vmagnin commented Oct 30, 2023

  • Move all test results to the demo folder to keep the main directory clean.

Well, I let them in the root directory to avoid directories separator problems (see https://fortran-lang.discourse.group/t/how-to-access-a-subdirectory-in-a-win-unix-compatible-way/6630), but the discussion shown that it may not be a problem with recent MS Windows system. We could also use the fpm option that can be used to define the working directory (well, I tried and failed but maybe I did something wrong).

* Add the `write_ppm_file_colorbar` subroutine as a type-bound procedure for the `Colormap` type.

Yes, the user can need it.

Move write_ppm_file_test to demo.f90 since it's a specific subroutine for the demo.

Yes, it seems logical.

gha3mi added a commit to gha3mi/forcolormap that referenced this issue Oct 31, 2023
@gha3mi
This commit references issues vmagnin#3, vmagnin#4, and vmagnin#5.
5e5c1dc 
Added 'colormap_parameters' module.
Added 'miscellaneous_colormaps' module.
Removed 'test' type-bound procedure.
Moved 'test' subroutine to demo and example1.
Added 'colorbar' type-bound procedure.
Renamed 'get_current' to 'get_name'.
Updated write_ppm_colorbar, set, and print subroutines.
Added pure/impure statements.
Bug fixes: changed 'intent(inout)' to 'intent(in)' in relevant functions.
Updated demo and example1.
@gha3mi gha3mi mentioned this issue Oct 31, 2023
Merged
@vmagnin vmagnin added the enhancement New feature or request label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vmagnin @gha3mi