Skip to content
This repository has been archived by the owner on Jun 16, 2020. It is now read-only.

Re-org to better accomodate manual additions. #7

Closed
vmbrasseur opened this issue May 29, 2013 · 2 comments
Closed

Re-org to better accomodate manual additions. #7

vmbrasseur opened this issue May 29, 2013 · 2 comments
Assignees

Comments

@vmbrasseur
Copy link
Owner

There's a problem with the current situation here.

Perl_Companies.* were created via scripts parsing job_postings.

If additions are inserted into these Perl_Companies.* files it screws any chances of re-parsing jobs_postings for better accuracy.

For now, to allow for manual additions to the list while avoiding the possibility of clobbering them, I'm going to have a separate file for those manual additions.

  • To keep everything tidy, this will include re-naming the existing files to help guide people away from manually editing them.
  • This also means changes to the scripts to make sure they write to the correct (new) filenames.
  • And, of course, README.md will need updating to reflect the new file structure and procedures.
@vmbrasseur
Copy link
Owner Author

In the pull request from @schmonz, he's corrected an entry in Perl_Companies.* rather than adding. This will complicate the (simple, band-aid, just getting by) solution proposed by this issue. The proposed solution would allow the incorrect data to remain in Perl_Companies.*.

So what really needs to happen is some sort of a diff between the manual additions and the parsed list, with conflicts resolved in favor of manual additions, to create a final list.

That may be out of scope of the "quick-fixiness" of this issue. Still thinking about that.

@vmbrasseur
Copy link
Owner Author

Resolved by 26bdca8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant