Fix: sizeof(pid_t) != sizeof(pthread_t) #211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real-time profiling code manages an array of threads to profile. This array is an array of
pthread_t
identifiers, but the code to allocate the array usessizeof(pid_t)
, which many not equalsizeof(pthread_t)
. In particular, on Linux 4.15 x86_64,sizeof(pthread_t) = 8
whilesizeof(pid_t) = 4
. This leads to crashes since the code will write beyond its allocated space.Based on git history, I believe this has existed since the introduction of
real_time
support in ccae9f7.Fixes #210.