This repository has been archived by the owner on Jul 15, 2021. It is now read-only.
fix bug where tokens can't refresh #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What happens if you don't need a Trusted CA? Shouldn't this be optional? |
craigtracey
suggested changes
Jan 16, 2019
|
It also looks like we need a rebase here. |
paulczar
force-pushed
the
ca-for-token
branch
from
fa65a8e
to
53046c1
Compare
paulczar
force-pushed
the
ca-for-token
branch
from
da15cf0
to
8660cd7
Compare
paulczar
force-pushed
the
ca-for-token
branch
2 times, most recently
from
8bdc98f
to
e840a9e
Compare
|
This field is effectively optional ... if its not provided the contents of the field in the kube config file or in the command line template will be an empty string which the kubeconfig config reader then ignores because its set to omit if empty in the kubeconfig object. |
Signed-off-by: Paul Czarkowski <username.taken@gmail.com> Signed-off-by: Jignesh Sheth <jsheth@pivotal.io>
when tokens expire the kubeclient needs to refresh them and that means it needs to trust the CA of the openid server, to do that we need to pass `idp-certificate-authority-data` through to the kubeconfig. Signed-off-by: Paul Czarkowski <username.taken@gmail.com> Signed-off-by: Jignesh Sheth <jsheth@pivotal.io>
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
|
it would be great to get this merged in ... its blocking gangway from working with PKS |
|
related to #148 |
|
Same, we bump into this issue when the dex CA is a self-signed CA. |
|
any updates? |
|
Would love to see this merged as well, it's currently blocking us as well with using dex. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when tokens expire the kubeclient needs to refresh them and that means
it needs to trust the CA of the openid server, to do that we need to
pass
idp-certificate-authority-datathrough to the kubeconfig.