This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
Container & Helm chart #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add option to disable SSL redirection * Not yet working with google auth
* Write config.js out when container starts * Provide config.js values through ENV * Unset oauth if value is empty as well as not provided
* Add docs
Because we run db migrations before the app starts, we need to guarentee that postgres is running before we try to start the postfacto container
crswty
force-pushed
the
feat-docker-release
branch
4 times, most recently
from
54ec3a2
to
764a6f4
Compare
crswty
force-pushed
the
feat-docker-release
branch
4 times, most recently
from
f1561e2
to
c6aa242
Compare
crswty
force-pushed
the
feat-docker-release
branch
from
c6aa242
to
fb93140
Compare
|
Hey @textbook could you take a look at at least the docker part of this? Happy to take feedback on the helm stuff as well if you have some but was expecting to probably not get a review of that part. |
textbook
approved these changes
Nov 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build docker container and adds a helm chart for deployment to kubernetes
I think this is ready for beta testing so am keen to merge it to start getting feedback. Check the README.md in the deployment/helm folder for more detail on how to use the chart.
I've taken a best stab at hooking this into the release process but suspect there will be some finessing once we merge to get it publishing properly. There are a couple of places where I need to change the repository from crswty/postfacto to pivotal/postfacto, i'll do that post review butt pre merge.
This addresses the following issues:
#191
#115
I have reviewed the contributing guide
I have made this pull request to the
masterbranchI have run all the tests using
./test.sh.I have added the copyright headers to each new file added
I have given myself credit in the humans.txt file (assuming I want to)