This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
Improving installation via Helm #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jenny Lea <jlea@pivotal.io>
Signed-off-by: Jenny Lea <jlea@pivotal.io> Signed-off-by: Othman Alkhamra <oalkhamra@pivotal.io>
Signed-off-by: Othman Alkhamra <oalkhamra@pivotal.io>
|
@th3n3rd Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@th3n3rd Thank you for signing the Contributor License Agreement! |
Signed-off-by: Othman Alkhamra <oalkhamra@pivotal.io>
crswty
approved these changes
May 13, 2020
Co-authored-by: Chris Whitty <1538281+crswty@users.noreply.github.com>
…tallation notes Signed-off-by: Othman Alkhamra <oalkhamra@pivotal.io>
Signed-off-by: Othman Alkhamra <oalkhamra@pivotal.io>
j-lea
referenced
this pull request
in j-lea/postfacto
May 21, 2020
* Update helm docker image used in CI * Move helm dependencies from requirements.yaml into Chart.yaml * Fix the port-forwarding notes in the helm chart * Document how to clean up state after helm uninstall Signed-off-by: Jenny Lea <jlea@pivotal.io> Signed-off-by: Othman Alkhamra <oalkhamra@pivotal.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to postfacto. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
Documents caveats when installing the helm chart locally and it fixes post-installation notes.
An explanation of the use cases your change solves
Improve helm chart development experience.
Links to any other associated PRs
I have reviewed the contributing guide
I have made this pull request to the
masterbranchI have run all the tests using
./test.sh.I have added the copyright headers to each new file added
I have given myself credit in the humans.txt file (assuming I want to)