This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Add basic GCP pricing support #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnarenpujari
force-pushed
the
feature/gcp-pricing
branch
5 times, most recently
from
221ebbb
to
06c415e
Compare
hemani19
reviewed
Jul 29, 2019
| * The following structs are modelled according to the GCP Pricing API response | ||
| * https://cloud.google.com/billing/v1/how-tos/catalog-api | ||
| */ | ||
|
|
|
@rnarenpujari, Thanks for your contribution. The code looks good to me. 🥇 Can you further add some tests for the GCP pricing? |
rnarenpujari
force-pushed
the
feature/gcp-pricing
branch
2 times, most recently
from
9d7e7ca
to
42c2614
Compare
Done |
rnarenpujari
force-pushed
the
feature/gcp-pricing
branch
from
42c2614
to
f310d1e
Compare
rnarenpujari
force-pushed
the
feature/gcp-pricing
branch
from
f310d1e
to
b6deb0a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Adds support to fetch and store the rate card from GCP