Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

RbVmomi 2.1.0 breaks PBM #159

Closed
agrare opened this issue Apr 18, 2019 · 6 comments
Closed

RbVmomi 2.1.0 breaks PBM #159

agrare opened this issue Apr 18, 2019 · 6 comments
Assignees
Labels

Comments

@agrare
Copy link
Contributor

agrare commented Apr 18, 2019

With rbvmomi-2.0.1:

>> require 'rbvmomi/pbm'
=> true
>> RbVmomi::PBM::PbmCapabilityProfile
=> RbVmomi::PBM::PbmCapabilityProfile

With rbvmomi-2.1.1

>> require 'rbvmomi/pbm'
=> true
>> RbVmomi::PBM::PbmCapabilityProfile
Traceback (most recent call last):
        3: from /usr/bin/irb:11:in `<main>'
        2: from (irb):4
        1: from /home/agrare/.gem/gems/rbvmomi-2.1.1/lib/rbvmomi/connection.rb:253:in `const_missing'
NameError (uninitialized constant RbVmomi::PBM::PbmCapabilityProfile)
@jrgarcia jrgarcia self-assigned this Apr 18, 2019
@jrgarcia jrgarcia added the bug label Apr 18, 2019
@agrare
Copy link
Contributor Author

agrare commented Apr 18, 2019

Looks like dynamicProperty attributes of PropertyChange were dropped also:

>> RbVmomi::VIM.PropertyChange(:dynamicProperty => [])
=> #<RbVmomi::VIM::PropertyChange:0x0000559a279ec9a8 @props={:dynamicProperty=>[]}>

with 2.1.1

>> require 'rbvmomi/vim'
=> true
>> RbVmomi::VIM.PropertyChange(:dynamicProperty => [])
Traceback (most recent call last):
        7: from /usr/bin/irb:11:in `<main>'
        6: from (irb):2
        5: from /home/agrare/.gem/gems/rbvmomi-2.1.1/lib/rbvmomi/connection.rb:260:in `method_missing'
        4: from /home/agrare/.gem/gems/rbvmomi-2.1.1/lib/rbvmomi/connection.rb:260:in `new'
        3: from /home/agrare/.gem/gems/rbvmomi-2.1.1/lib/rbvmomi/basic_types.rb:106:in `initialize'
        2: from /home/agrare/.gem/gems/rbvmomi-2.1.1/lib/rbvmomi/basic_types.rb:106:in `each'
        1: from /home/agrare/.gem/gems/rbvmomi-2.1.1/lib/rbvmomi/basic_types.rb:107:in `block in initialize'
RuntimeError (unexpected property name dynamicProperty)

@jrgarcia
Copy link
Contributor

Thanks for reporting @agrare! This whole generation process is crazy. I need to spend some time revamping it. 😩

@agrare
Copy link
Contributor Author

agrare commented Apr 18, 2019

@jrgarcia yeah I was thinking of trying to write a rake task to generate the vmodl.db automatically, or at least some spec tests to try to catch regressions.

Is it just generated from the publicly available wsdls or is anything else used?

@jrgarcia
Copy link
Contributor

Unfortunately, it's something internal. I'll see about creating a rake task to generate it from the public WSDL (like it should have been from the start!).

jrgarcia pushed a commit that referenced this issue Apr 22, 2019
It looks like 2.1.0 introduced a few changes to the VMODL database that
broke usage for several people. This update should fix the issue by
adding some of the things that are missing back into the VMODL database
file.

Fixes #157, #159

Signed-off-by: J.R. Garcia <jrg@vmware.com>
jrgarcia pushed a commit that referenced this issue Apr 26, 2019
It looks like 2.1.0 introduced a few changes to the VMODL database that
broke usage for several people. This update should fix the issue by
adding some of the things that are missing back into the VMODL database
file.

Fixes #157, #159

Signed-off-by: J.R. Garcia <jrg@vmware.com>
@agrare
Copy link
Contributor Author

agrare commented Apr 26, 2019

Thanks @jrgarcia !

@jrgarcia
Copy link
Contributor

@agrare v2.1.2 should be available from RubyGems. Sorry it took so long to get this out!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants