This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 95
Add log to dump kv_str #1388
Merged
Merged
Add log to dump kv_str #1388
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8f1796c
Add log to dump the kv_str reading from meta file.
lipingxue a9f3465
Change to trigger CI.
lipingxue ca88c8d
Change to run volume_access test as "runalways".
lipingxue 07d1e67
Set "policyList" to empty in SetupTest.
lipingxue 8d0ecb7
Address comments from Govindan.
lipingxue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,6 +57,10 @@ func (s *VsanTestSuite) SetUpSuite(c *C) { | |
} | ||
} | ||
|
||
func (s *VsanTestSuite) SetUpTest(c *C) { | ||
s.policyList = []string{} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor: As this is cleaning the list, this step should go to teardown. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I put it in the setup is to make sure each test is running from a clean state. I think either way works. So I will keep it as it is. |
||
} | ||
|
||
func (s *VsanTestSuite) TearDownTest(c *C) { | ||
if s.volumeName != "" { | ||
out, err := dockercli.DeleteVolume(s.config.DockerHosts[0], s.volumeName) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the default and hence need not be specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specified explicitly is more clear, and I found "basic_test.go" also specify "runalways".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we do need to add "runalways" explicitly - @shuklanirdesh82 can you please explain the difference between default (no tag) and "runalways"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a limitation of
go test -tags <tag_name>
command. There is no way to exclude any tag, as per-tags
tests are picked up with passed value and run. Any test files not labeled with tag falls into default category and end up running multiple times hence tag is required.Let me explain with following example. let's say we have 3 files a_test.go, b_test.go, c_test.go.
We have two targets
runalways
andrunonce
(https://github.com/vmware/docker-volume-vsphere/blob/master/vmdk_plugin/Makefile#L357).targets
runalways
: includes and ends up runninga_test.go
&c_test.go
targets
runonce
: includes and ends up runningb_test.go
&c_test.go
c_test.go
falls into default and ends up running multiple times hence the tag explicitly needed.