Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert web component does not detect the overflow in some cases #137

Closed
5 tasks
Alienah opened this issue Aug 4, 2022 · 3 comments · Fixed by #138
Closed
5 tasks

Alert web component does not detect the overflow in some cases #137

Alienah opened this issue Aug 4, 2022 · 3 comments · Fixed by #138

Comments

@Alienah
Copy link

Alienah commented Aug 4, 2022

Describe the bug

We are using the alert component in my team and we have encountered a problem. The content that we are introducing inside the slot has overflow, however the web component does not seem to detect it and therefore allow the scroll to be activated.

How to reproduce

Here we see an example using the same content inside the web component and outside the web component. We can see that in the second example (outside the web component) a scroll bar is displayed. That is the desired behaviour.

https://stackblitz.com/edit/clarity-javascript-demo-sjwgpi?file=src%2Findex.html

Steps to reproduce the behavior:

  1. Go to the index
  2. See the example showing a code content inside the alert box and outside the alert box

image

Expected behavior

We can see that in the second example (outside the web component) a scroll bar is displayed. That is the desired behaviour.

image

Versions

Clarity project:

  • [x ] Clarity Core
  • Clarity Angular/UI

Clarity version:

  • v5.x
  • [ x] v6.x

Framework:

  • Angular
  • React
  • Vue
  • [x ] Other:

Framework version:
Vanilla Javascript and HTML

Device:

  • Type: [MacBook]
  • OS: [iOS]
  • Browser [chrome]
  • Version [103.0.5060.134 ]

Additional notes

Add any other notes about the problem here.

ashleyryan pushed a commit to ashleyryan/core that referenced this issue Aug 4, 2022
- flexbox has some quirks with overflow
- setting min-width: 0 prevents the content from overflowing

fixes vmware-clarity#137
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Aug 5, 2022
- flexbox has some quirks with overflow
- setting min-width: 0 prevents the content from overflowing

fixes vmware-clarity#137
ashleyryan pushed a commit that referenced this issue Aug 15, 2022
- flexbox has some quirks with overflow
- setting min-width: 0 prevents the content from overflowing

fixes #137
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Aug 15, 2022
- flexbox has some quirks with overflow
- setting min-width: 0 prevents the content from overflowing

fixes vmware-clarity#137
ashleyryan pushed a commit that referenced this issue Aug 15, 2022
- flexbox has some quirks with overflow
- setting min-width: 0 prevents the content from overflowing

fixes #137
@github-actions
Copy link

🎉 This issue has been resolved in version 5.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 6.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant