Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): prevent content from overflowing alert #138

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

ashleyryan
Copy link
Contributor

  • flexbox has some quirks with overflow
  • setting min-width: 0 prevents the content from overflowing

fixes #137

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Content with overflow-x: auto that would otherwise render a scrollbar in a small container are instead overflowing the alert

Issue Number: #137

What is the new behavior?

add min-width: 0 to allow content to be smaller than the implied width: https://css-tricks.com/flexbox-truncated-text/

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

👋 @ashleyryan,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

projects/core/src/alert/alert.element.spec.ts Outdated Show resolved Hide resolved
projects/core/src/alert/alert.element.spec.ts Outdated Show resolved Hide resolved
projects/core/src/alert/alert.element.spec.ts Show resolved Hide resolved
projects/core/src/alert/alert.element.spec.ts Outdated Show resolved Hide resolved
- flexbox has some quirks with overflow
- setting min-width: 0 prevents the content from overflowing

fixes vmware-clarity#137
@ashleyryan ashleyryan dismissed kevinbuhmann’s stale review August 15, 2022 14:24

I made the changes that I could make

@ashleyryan ashleyryan merged commit f348776 into vmware-clarity:main Aug 15, 2022
@ashleyryan ashleyryan deleted the asryan/alert-overflow branch August 15, 2022 14:24
@github-actions
Copy link

🎉 This PR is included in version 6.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert web component does not detect the overflow in some cases
4 participants