Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect export for CdsRadioPanel #24

Closed
4 of 10 tasks
ashleyryan opened this issue Apr 6, 2022 · 3 comments · Fixed by #35
Closed
4 of 10 tasks

Incorrect export for CdsRadioPanel #24

ashleyryan opened this issue Apr 6, 2022 · 3 comments · Fixed by #35
Labels
project:@cds/react released on @beta released type:fix

Comments

@ashleyryan
Copy link
Contributor

Describe the bug

CdsRadioPanel is returning a wrapped version of cds-radio, not cds-radio-panel

How to reproduce

https://stackblitz.com/edit/clarity-react-penqcm?file=src%2FApp.tsx

Notice that the rendered element is a cds-radio

Expected behavior

It should be a cds-radio-panel. The issue is the name of the element on this line:

core/packages/react/src/selection-panels/radio/index.tsx

Line 7 in 62d2502

export const CdsRadioPanel = createComponent(React, 'cds-radio', RadioPanel, {}, 'CdsRadioPanel');

Versions

Clarity project:

  • Clarity Core
  • Clarity Angular/UI

Clarity version:

  • v3.x
  • v4.x
  • v5.x
  • v6.x

Framework:

  • Angular
  • React
  • Vue
  • Other:
This was referenced Apr 6, 2022
Closed
Closed
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Apr 14, 2022
fix(radio-panel): wrap correct component for react radiopanal
4b2ccda 
CdsRadioPanel previously wrapped cds-radio, not cds-radio-panel

Fixes vmware-clarity#24

Signed-off-by: Ashley Ryan <asryan@vmware.com>
@ashleyryan ashleyryan mentioned this issue Apr 14, 2022
Merged
14 tasks
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Apr 14, 2022
fix(react:selection-panel): wrap cds-radio-panel instead of cds-radio
e5f1faf 
Fixes vmware-clarity#24

Signed-off-by: Ashley Ryan <asryan@vmware.com>
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Apr 15, 2022
fix(react:selection-panel): wrap cds-radio-panel instead of cds-radio
b2b27bd 
Fixes vmware-clarity#24

Signed-off-by: Ashley Ryan <asryan@vmware.com>
@ashleyryan ashleyryan mentioned this issue Apr 15, 2022
Merged
14 tasks
ashleyryan pushed a commit that referenced this issue Apr 18, 2022
@ashleyryan
fix(react:selection-panel): wrap cds-radio-panel instead of cds-radio
22e5991 
Fixes #24

Signed-off-by: Ashley Ryan <asryan@vmware.com>
ashleyryan pushed a commit that referenced this issue Apr 18, 2022
@ashleyryan
fix(react:selection-panel): wrap cds-radio-panel instead of cds-radio
4126ef6 
Fixes #24

Signed-off-by: Ashley Ryan <asryan@vmware.com>
@github-actions
Copy link

🎉 This issue has been resolved in version 5.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 6.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented May 3, 2022

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
project:@cds/react released on @beta released type:fix
Projects
None yet
Milestone
No milestone
1 participant
@ashleyryan