Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react:panel): use correct element in CdsRadioPanel #26

Conversation

dsharp-pivotal
Copy link

@dsharp-pivotal dsharp-pivotal commented Apr 6, 2022

Signed-off-by: David Sharp dsharp@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

CdsRadioPanel is returning a wrapped version of cds-radio, not cds-radio-panel

Closes #24

What is the new behavior?

It wraps the correct element, cds-radio

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Signed-off-by: David Sharp <dsharp@vmware.com>
@ashleyryan
Copy link
Contributor

@steve-haar do you know why the vmwclabot is still pending?

@steve-haar
Copy link
Contributor

@dsharp-pivotal, I think you have to sign the contribution agreement: https://cla.vmware.com/cla/378e76cf732548f3b31de110d744071e

@dsharp-pivotal
Copy link
Author

@steve-haar Are you sure? I'm a VMware employee, and I joined the vmware-clarity organization. The bot labeled this commit "cla-not-required". On #25, the bot posted a link to https://cla.vmware.com/employee, which says "VMware employees do not need to sign a CLA to have changes merged to a repository owned by a VMware organization." and provides instructions to join the org.

@ashleyryan ashleyryan closed this Apr 14, 2022
@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect export for CdsRadioPanel
6 participants