New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CdsAlert: close button is slightly misaligned in v6 #92
Comments
ashleyryan
pushed a commit
to ashleyryan/core
that referenced
this issue
Jun 21, 2022
ashleyryan
pushed a commit
to ashleyryan/core
that referenced
this issue
Jun 21, 2022
also pass icon size prop through button action element fixes vmware-clarity#92
14 tasks
ashleyryan
pushed a commit
to ashleyryan/core
that referenced
this issue
Jun 21, 2022
also pass icon size prop through button action element fixes vmware-clarity#92
ashleyryan
pushed a commit
to ashleyryan/core
that referenced
this issue
Jun 21, 2022
also pass icon size prop through button action element fixes vmware-clarity#92
ashleyryan
pushed a commit
that referenced
this issue
Jun 22, 2022
also pass icon size prop through button action element fixes #92
🎉 This issue has been resolved in version 6.0.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
The bigger hit target on the close button is really great, unfortunately it comes with a slight misalignment compared to v5:
How to reproduce
Reproduction sandbox: https://codesandbox.io/s/alert-close-btn-issue-v6-3spmvx?file=/src/App.tsx
Weirdly I couldn't reproduce the "correct" behavior we're seeing in v5 on a sandbox, but we do get the correct alignment in our component library as shown on the screenshots here.
For reference: https://codesandbox.io/s/alert-close-btn-issue-v5-7eve0z?file=/src/App.tsx
Expected behavior
Versions
Clarity project:
Clarity version:
Framework:
Framework version:
React 17
The text was updated successfully, but these errors were encountered: