Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CdsAlert: close button is slightly misaligned in v6 #92

Closed
3 of 8 tasks
astorije opened this issue Jun 9, 2022 · 2 comments · Fixed by #109
Closed
3 of 8 tasks

CdsAlert: close button is slightly misaligned in v6 #92

astorije opened this issue Jun 9, 2022 · 2 comments · Fixed by #109
Assignees

Comments

@astorije
Copy link
Contributor

astorije commented Jun 9, 2022

Describe the bug

The bigger hit target on the close button is really great, unfortunately it comes with a slight misalignment compared to v5:

v5 v6
Screen Shot 2022-06-08 at 8 16 33 PM Screen Shot 2022-06-08 at 8 15 56 PM

How to reproduce

Reproduction sandbox: https://codesandbox.io/s/alert-close-btn-issue-v6-3spmvx?file=/src/App.tsx

Screen Shot 2022-06-08 at 8 12 38 PM

Weirdly I couldn't reproduce the "correct" behavior we're seeing in v5 on a sandbox, but we do get the correct alignment in our component library as shown on the screenshots here.
For reference: https://codesandbox.io/s/alert-close-btn-issue-v5-7eve0z?file=/src/App.tsx

Expected behavior

Screen Shot 2022-06-08 at 8 13 47 PM

Versions

Clarity project:

  • Clarity Core
  • Clarity Angular/UI

Clarity version:

  • v5.x
  • v6.x

Framework:

  • Angular
  • React
  • Vue
  • Other:

Framework version:

React 17

ashleyryan pushed a commit to ashleyryan/core that referenced this issue Jun 21, 2022
@ashleyryan ashleyryan self-assigned this Jun 21, 2022
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Jun 21, 2022
also pass icon size prop through button action element

fixes  vmware-clarity#92
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Jun 21, 2022
also pass icon size prop through button action element

fixes  vmware-clarity#92
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Jun 21, 2022
also pass icon size prop through button action element

fixes  vmware-clarity#92
ashleyryan pushed a commit that referenced this issue Jun 22, 2022
also pass icon size prop through button action element

fixes  #92
@github-actions
Copy link

🎉 This issue has been resolved in version 6.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants