fix(alert): fix alert close button positioning #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @ashleyryan,
Thank you, 🤖 Clarity Release Bot |
ashleyryan
force-pushed
the
asryan/alert-close-icon
branch
from
fec134b
to
273a5ad
Compare
also pass icon size prop through button action element fixes vmware-clarity#92
ashleyryan
force-pushed
the
asryan/alert-close-icon
branch
from
273a5ad
to
a71102c
Compare
steve-haar
approved these changes
Jun 22, 2022
|
🎉 This PR is included in version 6.0.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The icon positioning of the close button is slightly off.
Issue Number: #92
What is the new behavior?
The close button now has the same padding on the top that the left icon and text does to they're all lined up. It sets the padding on the bottom of the icon to 0, so as to not increase the height of the component.
There was also an icon-size attribute being set on the
cds-internal-close-buttoncomponent that wasn't being used, so I piped that through to thecds-iconunderneath to fix the size of the iconDoes this PR introduce a breaking change?
Other information