Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(navigation): sync state with newly added nav items #156

Merged
merged 2 commits into from
Aug 24, 2022
Merged

fix(navigation): sync state with newly added nav items #156

merged 2 commits into from
Aug 24, 2022

Commits on Aug 24, 2022

  1. chore(navigation): reorder lifecycle events for readability

    Ashley Ryan committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    87871de View commit details
    Browse the repository at this point in the history

  2. fix(navigation): sync state with newly added nav items 

    fixes  vmware-clarity#155 vmware-clarity#82

- previously only nav items in the initial render were synced with the top level expanded state
- add onslotchange to check for that
- move tabindex logic to slot change handler as well
- update unit tests to check syncing after component updates
    Ashley Ryan committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    fcbd0cd View commit details
    Browse the repository at this point in the history