Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkbox): add group container #1212

Conversation

mivaylo
Copy link
Contributor

@mivaylo mivaylo commented Feb 7, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mivaylo mivaylo marked this pull request as draft February 7, 2024 20:23
Copy link
Contributor

github-actions bot commented Feb 7, 2024

👋 @mivaylo,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

github-actions bot commented Feb 7, 2024

This PR introduces visual changes: 9568158
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-1616-checkbox-container-required-validation-group-container
git fetch https://github.com/vmware-clarity/ng-clarity.git 95681588c741e67ce8efc36303466abe97a6742a
git cherry-pick 95681588c741e67ce8efc36303466abe97a6742a
git push

Copy link
Contributor

github-actions bot commented Feb 7, 2024

This PR introduces visual changes: 777e460
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-1616-checkbox-container-required-validation-group-container
git fetch https://github.com/vmware-clarity/ng-clarity.git 777e4609b9b1d4df01c617767602ec690e04b07e
git cherry-pick 777e4609b9b1d4df01c617767602ec690e04b07e
git push

Copy link
Contributor

github-actions bot commented Feb 7, 2024

This PR introduces visual changes: 5bc69c2
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-1616-checkbox-container-required-validation-group-container
git fetch https://github.com/vmware-clarity/ng-clarity.git 5bc69c2ad554939fd4252b98455394430a70c986
git cherry-pick 5bc69c2ad554939fd4252b98455394430a70c986
git push

Copy link
Contributor

github-actions bot commented Feb 7, 2024

This PR introduces visual changes: 75443e2
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-1616-checkbox-container-required-validation-group-container
git fetch https://github.com/vmware-clarity/ng-clarity.git 75443e29103dca1e15296494a311cca92cce73fb
git cherry-pick 75443e29103dca1e15296494a311cca92cce73fb
git push

Comment on lines +33 to +40
this.ngControlService.controlChanges.subscribe(controls => {
this.controls = controls;
// Subscribe to the status change events, only after touched
// and emit the control
if (this.controls?.length > 0) {
this.controls.map(control => {
this.subscriptions.push(
control.statusChanges?.subscribe(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should compose this into one subscription using operators.

Copy link
Member

@kevinbuhmann kevinbuhmann Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, subscription should occur in ngOnInit or some other lifecycle hook.

Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants