-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(checkbox): add group container #1212
feat(checkbox): add group container #1212
Conversation
👋 @mivaylo,
Thank you, 🤖 Clarity Release Bot |
This PR introduces visual changes: 9568158
|
This PR introduces visual changes: 777e460
|
This PR introduces visual changes: 5bc69c2
|
This PR introduces visual changes: 75443e2
|
this.ngControlService.controlChanges.subscribe(controls => { | ||
this.controls = controls; | ||
// Subscribe to the status change events, only after touched | ||
// and emit the control | ||
if (this.controls?.length > 0) { | ||
this.controls.map(control => { | ||
this.subscriptions.push( | ||
control.statusChanges?.subscribe(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should compose this into one subscription using operators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, subscription should occur in ngOnInit
or some other lifecycle hook.
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information