Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cds theme switcher to storybook #199

Merged
merged 6 commits into from
Jun 27, 2022

Conversation

kevinbuhmann
Copy link
Member

@kevinbuhmann kevinbuhmann commented Jun 27, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • [N/A] Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • [N/A] If applicable, have a visual design approval

PR Type

Storybook

What is the current behavior?

There is no theme switcher.

What is the new behavior?

You can switch between the default, cds light, and cds dark themes. The theme is only applied to the preview canvas, not the manager.

Does this PR introduce a breaking change?

No.

@kevinbuhmann kevinbuhmann changed the title Kevin/storybook theme switcher chore: add cds theme switcher to storybook Jun 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2022

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann kevinbuhmann merged commit 9e10867 into main Jun 27, 2022
@kevinbuhmann kevinbuhmann deleted the kevin/storybook-theme-switcher branch June 27, 2022 21:38
@github-actions
Copy link
Contributor

🎉 This PR is included in version 13.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants