Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iso_url in builder configuration blocks #235

Closed
1 task done
MarRio81 opened this issue Jul 27, 2022 · 4 comments · Fixed by #249
Closed
1 task done

Add support for iso_url in builder configuration blocks #235

MarRio81 opened this issue Jul 27, 2022 · 4 comments · Fixed by #249
Assignees
Labels
type/enhancement Enhancement
Milestone

Comments

@MarRio81
Copy link

MarRio81 commented Jul 27, 2022

Code of Conduct

  • I have read and agree to the project's Code of Conduct.

Description

Please add support for iso_url in builder configuration blocks for each Linux and Windows images.

Use Case(s)

This makes managing ISO files unnecessary.

Potential Configuration

TBD

References

https://www.packer.io/plugins/builders/vsphere/vsphere-iso#iso-configuration

@MarRio81 MarRio81 changed the title Add support for iso_url builder configuration blocks Add support for iso_url in builder configuration blocks Jul 27, 2022
@tenthirtyam tenthirtyam added this to the v22.08 milestone Jul 27, 2022
@tenthirtyam tenthirtyam added the status/planned Planned label Jul 27, 2022
@tenthirtyam
Copy link
Contributor

tenthirtyam commented Jul 27, 2022

Thanks for submitting the issue.

This enhancement is already planned, but the project will retain iso_path as the default configuration as not all ISOs are publicly available.

Note

I should also mention that I've considered adding a Terraform configuration to automate adding the ISOs as well.

Please consider adding a GitHub star ⭐️ for the project. It really helps!

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

@tenthirtyam tenthirtyam changed the title Add support for iso_url in builder configuration blocks Add support for iso_url in builder configuration blocks Jul 27, 2022
@Joffrey54
Copy link

You can use the iso_url for local files too. It uses go-getter

tenthirtyam added a commit that referenced this issue Aug 20, 2022
Add support for `iso_url` in the builder configuration blocks.

#235

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2022
@tenthirtyam tenthirtyam removed the status/needs-review Needs Review label Oct 7, 2022
@tenthirtyam
Copy link
Contributor

Based on further review and testing of options for #343, I will be reverting pull request #249 for this enhancement request and this project will remove support for iso_url.

@tenthirtyam tenthirtyam removed the status/planned Planned label Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/enhancement Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants