Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for iso_url in builder configuration #249

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

tenthirtyam
Copy link
Contributor

Summary of Pull Request

Add support for iso_url in the builder configuration blocks.

The project supports configuring the ISO from either a datastore or URL source. By default, the project uses the datastore source.

If you are using a URL source to obtain your guest operating system .iso files, you must update the input variables to use the URL source.

Update the iso_url variable to download the .iso from a URL. The iso_url variable takes presedence over any other iso_* variables.

Example: builds/<type>/<build>/*.auto.pkvars.hcl

iso_url = "https://artifactory.rainpole.io/iso/linux/photon/4.0/x86_64/photon-4.0-xxxxxxxxx.iso"

Signed-off-by: Ryan Johnson johnsonryan@vmware.com

Type of Pull Request

  • This is a bugfix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is something else.
    Please describe:

Related to Existing Issues

Closes: #235

Test and Documentation Coverage

  • Tests have been completed (for bugfixes / features).
  • Documentation has been added / updated (for bugfixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Add support for `iso_url` in the builder configuration blocks.

#235

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam added type/enhancement Enhancement priority/medium Priority Medium sev/low Low size/s Small labels Aug 20, 2022
@tenthirtyam tenthirtyam added this to the v22.08 milestone Aug 20, 2022
@tenthirtyam tenthirtyam self-assigned this Aug 20, 2022
@tenthirtyam tenthirtyam merged commit 758bb6b into main Aug 20, 2022
@tenthirtyam tenthirtyam deleted the feat/add-iso-url branch August 20, 2022 01:51
@tenthirtyam tenthirtyam changed the title feat: add support for iso_url builder configuration feat: add support for iso_url in builder configuration Aug 20, 2022
tenthirtyam added a commit that referenced this pull request Aug 20, 2022
Updates `CHANGELOG.md` to include the enhancement provided in #249.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/medium Priority Medium sev/low Low size/s Small type/enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for iso_url in builder configuration blocks
1 participant