Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update .gitignore terraform/artifacts #476

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

tintinhamans
Copy link
Contributor

Summary of Pull Request

  1. Updated .gitignore to correctly ignore .vmdk, .nvram, .ovf and .mf files.
  2. Added tfplan files to .gitignore, also added additional ignores here to match the GitHub template.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.

Related to Existing Issues

Resolves #472

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tintinhamans tintinhamans requested a review from a team as a code owner February 11, 2023 14:06
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tenthirtyam tenthirtyam merged commit fc535bc into vmware-samples:main Feb 11, 2023
@tintinhamans tintinhamans deleted the feat/update-gitignore branch February 13, 2023 21:16
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
@tenthirtyam tenthirtyam added this to the .Next milestone Sep 16, 2023
@tenthirtyam tenthirtyam self-assigned this Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.gitignore is incomplete
2 participants