feat: add url check before download #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthirtyam
requested review from
tenthirtyam
and removed request for
GaryJBlake
tenthirtyam
force-pushed
the
feat/add-url-for-file-download
branch
from
f607707
to
2529969
Compare
tenthirtyam
reviewed
Apr 15, 2024
tenthirtyam
reviewed
Apr 15, 2024
tenthirtyam
requested changes
Apr 15, 2024
tenthirtyam
force-pushed
the
feat/add-url-for-file-download
branch
2 times, most recently
from
f8ede74
to
c783656
Compare
Removes the PowerShell provisioner for Windows 11 and 10 as it's not required currently after the transition to Ansible. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
Adds a script (`./download.sh`) and a configuration (`project.json`) to assist in the download of the guest operating systems. Signed-off-by: Jared Burns <jared.burns@broadcom.com> Co-authored-by: Ryan Johnson <ryan.johnson@broadcom.com>
added ISO check before starting download. this will prevent download from starting if iso exist. Signed-off-by: Jared Burns <jared.burns@broadcom.com>
Added a check to verify a download URL before starting the download of an ISO. Signed-off-by: Jared Burns <jared.burns@broadcom.com>
tenthirtyam
force-pushed
the
feat/add-url-for-file-download
branch
from
c783656
to
d4bb321
Compare
Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
tenthirtyam
approved these changes
Apr 15, 2024
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Pull Request
Added a check to verify a download URL before starting the download of an ISO.
Type of Pull Request
type/bugtype/featureortype/enhancementtype/docstype/refactortype/chorePlease describe:
Related to Existing Issues
Issue Number: N/A
Test and Documentation Coverage
Breaking Changes?