Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gos iso download automation #874

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Apr 11, 2024

Summary of Pull Request

Adds a script (./download.sh) and a configuration (project.json) to assist in the download of the guest operating systems.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@burnsjared0415 burnsjared0415 requested a review from a team as a code owner April 11, 2024 22:47
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Apr 11, 2024
Adds a script (`./download.sh`) and a configuration (`project.json`) to assist in the download of the guest operating systems.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
Co-Authored-By: Ryan Johnson <ryan.johnson@broadcom.com>
Co-Authored-By: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam changed the title feat: Add automated iso download feat: gos iso download automation Apr 12, 2024
@tenthirtyam tenthirtyam added this to the v0.20.0 milestone Apr 12, 2024
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Was fun to work on this with you!

@tenthirtyam tenthirtyam merged commit fb0e71e into vmware-samples:develop Apr 12, 2024
tenthirtyam added a commit that referenced this pull request Apr 15, 2024
Adds a script (`./download.sh`) and a configuration (`project.json`) to assist in the download of the guest operating systems.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
Co-authored-by: Ryan Johnson <ryan.johnson@broadcom.com>
tenthirtyam added a commit that referenced this pull request Apr 15, 2024
Adds a script (`./download.sh`) and a configuration (`project.json`) to assist in the download of the guest operating systems.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
Co-authored-by: Ryan Johnson <ryan.johnson@broadcom.com>
tenthirtyam added a commit that referenced this pull request Apr 15, 2024
Adds a script (`./download.sh`) and a configuration (`project.json`) to assist in the download of the guest operating systems.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
Co-authored-by: Ryan Johnson <ryan.johnson@broadcom.com>
tenthirtyam added a commit that referenced this pull request Apr 15, 2024
* fix: windows pwsh provisioner (#879)

Removes the PowerShell provisioner for Windows 11 and 10 as it's not required currently after the transition to Ansible.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>

* feat: gos iso download automation (#874)

Adds a script (`./download.sh`) and a configuration (`project.json`) to assist in the download of the guest operating systems.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
Co-authored-by: Ryan Johnson <ryan.johnson@broadcom.com>

* feat: added iso check

Added a check for an existing ISO before starting download to prevent an unecessart download from starting,

Signed-off-by: Jared Burns <jared.burns@broadcom.com>

---------

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
Signed-off-by: Jared Burns <jared.burns@broadcom.com>
Co-authored-by: Ryan Johnson <ryan.johnson@broadcom.com>
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required Contributor License Agreement Not Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants